From 9e6bc60abe6dfdaa54793d8d881be2d59d44f509 Mon Sep 17 00:00:00 2001
From: Nolan Lawson <nolan@nolanlawson.com>
Date: Sat, 11 May 2019 10:01:14 -0700
Subject: [PATCH] fix: improve focus style on dialog list item (#1208)

fixes #1201
---
 .../dialog/components/GenericDialogList.html    | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/src/routes/_components/dialog/components/GenericDialogList.html b/src/routes/_components/dialog/components/GenericDialogList.html
index 39494f9f..768aa757 100644
--- a/src/routes/_components/dialog/components/GenericDialogList.html
+++ b/src/routes/_components/dialog/components/GenericDialogList.html
@@ -1,7 +1,10 @@
 <ul class="generic-dialog-list">
   {#each items as item (item.key)}
   <li class="generic-dialog-list-item">
-    <button class="generic-dialog-list-button" on:click="fire('click', item)">
+    <button
+        class="generic-dialog-list-button"
+        on:applyFocusStylesToParent="noop()"
+        on:click="fire('click', item)">
       <SvgIcon className="generic-dialog-list-item-svg" href={item.icon} />
       <span class="generic-dialog-list-button-span">
         {item.label}
@@ -26,6 +29,7 @@
     border: 1px solid var(--settings-list-item-border);
     font-size: 1.2em;
     display: flex;
+    outline-width: 4px;
   }
   :global(.generic-dialog-list-item-svg) {
     width: 24px;
@@ -41,6 +45,9 @@
     display: flex;
     flex-direction: row;
   }
+  .generic-dialog-list-button:focus {
+    outline: none; /* focus style is on parent instead */
+  }
   .generic-dialog-list-button-span {
     flex: 1;
     margin-left: 20px;
@@ -86,8 +93,16 @@
 </style>
 <script>
   import SvgIcon from '../../SvgIcon.html'
+  import { applyFocusStylesToParent } from '../../../_utils/events'
+  import noop from 'lodash-es/noop'
 
   export default {
+    events: {
+      applyFocusStylesToParent
+    },
+    methods: {
+      noop
+    },
     components: {
       SvgIcon
     }