From 91f954de3616b4901c4affc72d9ea712c04f3ce1 Mon Sep 17 00:00:00 2001 From: Nolan Lawson Date: Tue, 12 Feb 2019 21:43:04 -0800 Subject: [PATCH] perf: reduce server-side memory usage of Pinafore (#973) fixes #971 --- Dockerfile | 6 ++++-- README.md | 2 +- package.json | 3 +-- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/Dockerfile b/Dockerfile index 564abf7b..cb9df77a 100644 --- a/Dockerfile +++ b/Dockerfile @@ -19,5 +19,7 @@ RUN yarn build # Expose port 4002 EXPOSE 4002 -# Setting run-command -CMD PORT=4002 yarn start +# Setting run-command, using explicit `node` command +# rather than `yarn` or `npm` to use less memory +# https://github.com/nolanlawson/pinafore/issues/971 +CMD PORT=4002 node __sapper__/build diff --git a/README.md b/README.md index 7af43ce9..4685656a 100644 --- a/README.md +++ b/README.md @@ -58,7 +58,7 @@ To build Pinafore for production: yarn --pure-lockfile yarn build - PORT=4002 yarn start + PORT=4002 node __sapper__/build ### Docker diff --git a/package.json b/package.json index 55f78da2..bdf3a682 100644 --- a/package.json +++ b/package.json @@ -8,12 +8,11 @@ "dev": "run-s build-template-html build-third-party-assets serve-dev", "serve-dev": "run-p --race build-template-html-watch sapper-dev", "sapper-dev": "cross-env NODE_ENV=development PORT=4002 sapper dev", - "sapper-prod": "cross-env PORT=4002 node __sapper__/build", "before-build": "run-s build-template-html build-third-party-assets", "build": "cross-env NODE_ENV=production run-s build-steps", "build-steps": "run-s before-build sapper-build", "sapper-build": "sapper build", - "start": "cross-env NODE_ENV=production run-s sapper-prod", + "start": "PORT=4002 node __sapper__/build", "build-and-start": "run-s build start", "build-template-html": "node -r esm ./bin/build-template-html.js", "build-template-html-watch": "node -r esm ./bin/build-template-html.js --watch",